Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include enumeration of missing permissions in error log #1009

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

include enumeration of missing permissions in error log #1009

wants to merge 1 commit into from

Conversation

kurahaupo
Copy link
Collaborator

put extra info in log to help diagnose #1008

@kurahaupo kurahaupo mentioned this pull request Jan 4, 2020
Open
@kurahaupo
Copy link
Collaborator Author

The travis-ci failure is because com.android.billingclient:billing has been updated.

> Lint found errors in the project; aborting build.
  
  Fix the issues identified by lint, or add the following to your build script to proceed with errors:
  ...
  android {
      lintOptions {
          abortOnError false
      }
  }
  ...
  
  Errors found:
  
  /home/travis/build/jberkel/sms-backup-plus/app/build.gradle:58: Error:
 A newer version of com.android.billingclient:billing than 2.0.3 is available: 2.1.0 [GradleDependency]
      implementation 'com.android.billingclient:billing:2.0.3'
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@kurahaupo
Copy link
Collaborator Author

@jberkel I'm loath to push any patch where the CI fails, even though that appears to be unrelated to the patch. Your advice would be much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kurahaupo